Skip to content

Fix GH_HOST mismatch and false fork detection on issue_comment events#24210

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/fix-gh-host-configuration-issue
Closed

Fix GH_HOST mismatch and false fork detection on issue_comment events#24210
Copilot wants to merge 2 commits intomainfrom
copilot/fix-gh-host-configuration-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026 •
edited
Loading

Two bugs cause gh pr checkout to fail when a workflow is triggered by an issue_comment event on a non-fork PR in a public GitHub repo.

False "Fork PR detected" warning

For issue_comment events, the PR object is constructed with only {number, state} — no head/base data. detectForkPR treated a missing head identically to a deleted fork's null head.repo, producing a spurious isFork: true.

Before:

if (!pullRequest.head?.repo) {  // true when head is absent entirely
  isFork = true;
  reason = "head repository deleted (was likely a fork)";
}

After:

if (!pullRequest.head) {
  isFork = false;               // can't determine — not a fork signal
  reason = "head information not available";
} else if (!pullRequest.head.repo) {
  isFork = true;                // head exists but repo null → deleted fork
  reason = "head repository deleted (was likely a fork)";
}

gh pr checkout fails when GH_HOST is set to a mismatched host

If GH_HOST is set to a GHE hostname but git remotes point to github.com, gh errors:

none of the git remotes configured for this repository correspond to the GH_HOST environment variable

Adds buildGHExecEnv() which derives the correct host from GITHUB_SERVER_URL and passes it to gh pr checkout:

  • github.com → deletes GH_HOST from the exec env (lets gh default)
  • GHE hostname → sets GH_HOST to match the server URL

buildGHExecEnv is exported for direct unit testing.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md
    • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs --conditions node --conditions development /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git conf�� user.name lure tions/setup/js/node_modules/.bin/git -M main /usr/sbin/git git init�� --bare --initial-branch=main k/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/git '/tmp/bare-incregit '/tmp/bare-increadd cal/bin/git git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 3, 2026 that may be closed by this pull request
Failure due to GH_HOST not configured when fetching PR #24208
Closed
@dsyme
Fix GH_HOST mismatch and false fork detection for issue_comment events
f2dd8e0 
- detectForkPR: distinguish missing head (issue_comment) from deleted fork
- checkout_pr_branch: derive GH_HOST from GITHUB_SERVER_URL for gh pr checkout
- Export buildGHExecEnv for testability
- Update tests to cover new behavior and GH_HOST env handling

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0b58e70b-2a3d-4f86-9c9c-98c42054af41

Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix GH_HOST not configured when fetching PR Fix GH_HOST mismatch and false fork detection on issue_comment events Apr 3, 2026
Copilot AI requested a review from dsyme April 3, 2026 01:34
Copilot finished work on behalf of dsyme April 3, 2026 01:34
@lpcox
Copy link
Copy Markdown
Collaborator

lpcox commented Apr 3, 2026

Addressed in #24221

@lpcox lpcox closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme Awaiting requested review from dsyme

Assignees

@dsyme dsyme

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure due to GH_HOST not configured when fetching PR

3 participants

@lpcox @dsyme